Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break the Windows' EOL. #39

Merged
merged 1 commit into from
Mar 12, 2013
Merged

Don't break the Windows' EOL. #39

merged 1 commit into from
Mar 12, 2013

Conversation

dduponchel
Copy link
Collaborator

I still don't see why this was here, but the unit tests are clear : this string.replace was useless !

@dduponchel
Don't break the Windows' EOL.
64f2732 
I still don't see why this was here... Fixes Stuk#38.
Stuk added a commit that referenced this pull request Mar 12, 2013
@Stuk
Merge pull request #39 from dduponchel/issue38
131ce25 
Don't break the Windows' EOL.
@Stuk Stuk merged commit 131ce25 into Stuk:master Mar 12, 2013
@Stuk
Copy link
Owner

Stuk commented Mar 12, 2013

Cool, some overzealous borrowing of code on my part.

@dduponchel dduponchel deleted the issue38 branch March 12, 2013 08:43
@dduponchel
Copy link
Collaborator Author

@Stuk don't worry, I was the one who added this string.replace ! But I still don't know why the original code has this line and why I didn't removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dduponchel @Stuk