New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the memory consumption #449

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Aug 22, 2017

A pako object contains a 64k buffer. We create a FlateWorker for each zip
entry, meaning a zip file with a lot of entries would take a lot of memory.

Lazy-loading the pako object isn't the best solution but it's the quickest.
The best solution is to lazy-load the worker list.

Mitigate the issue #446.

Lower the memory consumption
A pako object contains a 64k buffer. We create a `FlateWorker` for each zip
entry, meaning a zip file with a lot of entries would take **a lot** of memory.

Lazy-loading the pako object isn't the best solution but it's the quickest.
The best solution is to lazy-load the worker list.

Mitigate the issue #446.

@dduponchel dduponchel merged commit 1f33862 into Stuk:master Aug 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:memory branch Aug 23, 2017

@dduponchel dduponchel referenced this pull request Aug 23, 2017

Merged

Release 3.1.4 #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment