New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the "unsupported format" error message #461

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Sep 10, 2017

The message was misleading and some users misunderstood it: JSZip doesn't
reject a file because of what the content actually is (json file, mp4
file, etc). It rejects a file because it is not a supported JavaScript
object (usually a plain object containing the buffer, not the buffer
directly).

The new message and the FAQ entry should help clear the
misunderstanding.

Improve the "unsupported format" error message
The message was misleading and some users misunderstood it: JSZip doesn't
reject a file because of what the content actually is (json file, mp4
file, etc). It rejects a file because it is not a supported JavaScript
object (usually a plain object containing the buffer, not the buffer
directly).

The new message and the FAQ entry should help clear the
misunderstanding.

@dduponchel dduponchel merged commit ad9fcdb into Stuk:master Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:unsupported_format branch Sep 14, 2017

@dduponchel dduponchel referenced this pull request Nov 9, 2017

Merged

Release 3.1.5 #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment