New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59, issue with the android default browser #60

Merged
merged 1 commit into from Oct 5, 2013

Conversation

Projects
None yet
2 participants
@dduponchel
Collaborator

dduponchel commented Aug 10, 2013

The default android browser shows some weird behavior... On some
versions String.fromCharCode.apply on a ArrayBuffer/Uint8Array will
fail, on other versions subarray returns wrong results
(u8with4elements.subarray(0, 65536) = u8with22elements).

Fix #59, issue with android default browser
The default android browser shows some weird behavior... On some
versions String.fromCharCode.apply on a ArrayBuffer/Uint8Array will
fail, on other versions subarray return wrong results
(u8with4elements.subarray(0, 65536) = u8with22elements).

At least, I can test this on the android emulator on linux.
}
} catch(e) {
canUseApply = false;
}

This comment has been minimized.

@Stuk

Stuk Aug 10, 2013

Owner

Wow, what's broken with apply?

@Stuk

Stuk Aug 10, 2013

Owner

Wow, what's broken with apply?

This comment has been minimized.

@dduponchel

dduponchel Aug 10, 2013

Collaborator

Some versions of the default android browser (4.x, tested in the emulator) doesn't accept ArrayBuffer or Uint8Array for apply, only arrays : I get a TypeError: Function.prototype.apply: Arguments list has wrong type.

@dduponchel

dduponchel Aug 10, 2013

Collaborator

Some versions of the default android browser (4.x, tested in the emulator) doesn't accept ArrayBuffer or Uint8Array for apply, only arrays : I get a TypeError: Function.prototype.apply: Arguments list has wrong type.

Stuk added a commit that referenced this pull request Oct 5, 2013

Merge pull request #60 from dduponchel/issue59
Fix #59, issue with the android default browser

@Stuk Stuk merged commit 5da7854 into Stuk:master Oct 5, 2013

@dduponchel dduponchel deleted the dduponchel:issue59 branch Oct 30, 2013

@dduponchel dduponchel referenced this pull request Jan 30, 2014

Closed

node 0.8 file name issue #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment