Fix #59, issue with the android default browser #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default android browser shows some weird behavior... On some versions String.fromCharCode.apply on a ArrayBuffer/Uint8Array will fail, on other versions subarray return wrong results (u8with4elements.subarray(0, 65536) = u8with22elements). At least, I can test this on the android emulator on linux.
| } | ||
| } catch(e) { | ||
| canUseApply = false; | ||
| } |
There was a problem hiding this comment.
Some versions of the default android browser (4.x, tested in the emulator) doesn't accept ArrayBuffer or Uint8Array for apply, only arrays : I get a TypeError: Function.prototype.apply: Arguments list has wrong type.
Stuk
added a commit
that referenced
this pull request
Oct 5, 2013
Fix #59, issue with the android default browser
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default android browser shows some weird behavior... On some
versions String.fromCharCode.apply on a ArrayBuffer/Uint8Array will
fail, on other versions subarray returns wrong results
(u8with4elements.subarray(0, 65536) = u8with22elements).