Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): redirect main to dist on browsers #742

Merged
merged 1 commit into from Feb 10, 2021

Conversation

@jahed
Copy link
Contributor

@jahed jahed commented Feb 6, 2021

Fixes #724

Notes

#724 may be a bug with Webpack 5's . resolution. The standard isn't very well documented so it's hard to know expected behaviour.

However, I think it makes sense to redirect ./lib/index rather than . as it's the main module. Browserify's example uses this approach. This also fixes the Webpack 5 issue.

@Stuk Stuk merged commit dcc6ff9 into Stuk:master Feb 10, 2021
@jahed jahed deleted the fix/webpack-5-async-failure branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants