New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the unicode path extra field #82

Merged
merged 2 commits into from Feb 1, 2014

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Jan 19, 2014

This patch sets the unicode path extra field. unzip needs at least one
extra field to correctly handle unicode path, so using the path is as
good as any other information. This could improve the situation with
other archive managers too.

This field is usually used without the utf8 flag, with a non unicode
path in the header (winrar, winzip). This helps (a bit) with the messy
Windows' default compressed folders feature but breaks on p7zip which
doesn't seek the unicode path extra field.

So for now, UTF-8 everywhere !

Fix #79.

dduponchel added some commits Jan 19, 2014

Add support for the unicode path extra field
This patch sets the unicode path extra field. unzip needs at least one
extra field to correctly handle unicode path, so using the path is as
good as any other information. This could improve the situation with
other archive managers too.

This field is usually used without the utf8 flag, with a non unicode
path in the header (winrar, winzip). This helps (a bit) with the messy
Windows' default compressed folders feature but breaks on p7zip which
doesn't seek the unicode path extra field.

So for now, UTF-8 everywhere !

Fix #79.

dduponchel added a commit that referenced this pull request Feb 1, 2014

Merge pull request #82 from dduponchel/unicode_extra_field
Add support for the unicode path extra field

@dduponchel dduponchel merged commit 71eb5a1 into Stuk:master Feb 1, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details

@dduponchel dduponchel deleted the dduponchel:unicode_extra_field branch Feb 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment