Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate metadata types and expose OnUpdateCallback #852

Merged
merged 1 commit into from Jul 21, 2022
Merged

Conversation

Stuk
Copy link
Owner

@Stuk Stuk commented Jul 20, 2022

Metadata types were duplicated as Metadata (not exported) and JSZipMetadata (exported, and missing null type for currentFile).

This PR gets rid of Metadata and consolidates under JSZipMetadata.

From #851

Copy link

@emilbonnek emilbonnek left a comment

Works for me and provides a smoother typesafe story :)

Only got a tiny thing with currentFile not being nullable as before.

index.d.ts Outdated Show resolved Hide resolved
@Stuk Stuk merged commit f299cce into main Jul 21, 2022
1 check passed
@Stuk Stuk deleted the metadata-ts branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants