Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image loader to view loader while image is loading #278

Closed
wants to merge 4 commits into from

Conversation

snehalmasalkar
Copy link

No description provided.

@erickok
Copy link
Collaborator

erickok commented Jan 15, 2021

Let's discuss: #497

@tneotia tneotia mentioned this pull request Jan 17, 2021
@tneotia
Copy link
Collaborator

tneotia commented Feb 4, 2021

Hi there, thanks for this PR! With #505, we have finally added this capability into the library with a custom image rendering API (much better than the current customRender). You can see the discussion at #497 to see how it works. If you have any suggestions, please let @erickok know there. Again thanks for contributing! :)

erickok added a commit to vrtdev/flutter_html that referenced this pull request Feb 8, 2021
Copy link
Collaborator

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the story behind the massive lib/rich_text_parser.dart diff?

@ryan-berger
Copy link
Collaborator

Ooops, wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants