Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Image API #503

Closed

Conversation

tneotia
Copy link
Collaborator

@tneotia tneotia commented Jan 17, 2021

Fixes #130, #153, #172, #301, #386.
Implements #146, #156, #183, #235, #278, #496.
Todo #162, #304, #478.

Discussion at #497

See example/main.dart and html_parser.dart to see how the implementation works.
For those who are wishing for headers to be passed to images, please test this out against your use case and comment if you come across any issues.

@tneotia
Copy link
Collaborator Author

tneotia commented Jan 17, 2021

@ryan-berger let me know if this is something you'd like to merge after you take a look at it - I plan to extend the SVG functionality to support loading from assets and from base64, and also support pre-caching them, so I can either include all that in this PR (if it would be merged) or make a different one just for this.

@YeFei572
Copy link

good job!

@ryan-berger
Copy link
Collaborator

Are we going to close this one due to your other proposal and @erickok 's proposal @tneotia ?

@tneotia
Copy link
Collaborator Author

tneotia commented Jan 18, 2021

Are we going to close this one due to your other proposal and @erickok 's proposal @tneotia ?

Yep, I would just leave it be until we get either of those merged and then we can close this one and the other proposal that wasn't accepted.

@tneotia
Copy link
Collaborator Author

tneotia commented Feb 3, 2021

Closing since we are going with eric's PR (this is the old version anyways)

@tneotia tneotia closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request image with headers
3 participants