Re-submit fix #33 version 2 #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2016 16:44
As ian4hu pointed out in [#33](https://github.com/SublimeLinter/SublimeLinter-html-tidy/pull/SublimeLinter#33), Linter.which() called from within the HtmlTidy class definition resulted in an early invocation situation in which a fail test resulted for Linter's settings, _paths_ in particular, prior to any setting being cached. Changes to fix this.
Remove blank line before docstring
|
Argh.. spooked by #141 |
|
ah yes, please change |
added 2 commits
February 17, 2016 11:04
---ignore=D202 > --add-ignore=D202
Add 1 blank line before class docstring
|
Do you mean --add-ignore=D211? cause that is what failing the Travis check. |
pep257 add ignore D211 - No blank lines allowed before class docstring.
|
Nope, code should be corrected to |
Remove whitespace on blank before class docstring.
|
Ok, D202 stays. |
|
Ouch, reopening PR re-starts travis check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ian4hu pointed out in #33, Linter.which() called from within the HtmlTidy class definition resulted in an early invocation situation in which a fail test resulted for Linter's settings, paths in particular, prior to any setting being cached.
Changes to fix this.