Revert broadcasting lint_result_changed cache layer (#1692)

Revert broadcasting `lint_result_changed` cache layer
SublimeLinter · Nov 11, 2019 · 89a4f04 · 89a4f04
2 parents 02e02ee + e7e5f04
commit 89a4f04
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 18 deletions.
diff --git a/highlight_view.py b/highlight_view.py
@@ -74,7 +74,7 @@ def plugin_unloaded():
             undraw(view)
 
 
-@events.on('lint_result_changed')
+@events.on(events.LINT_RESULT)
 def on_lint_result(filename, linter_name, **kwargs):
     views = list(all_views_into_file(filename))
     if not views:

diff --git a/panel_view.py b/panel_view.py
@@ -81,7 +81,7 @@ def unzip(zipped):
     return tuple(zip(*zipped))  # type: ignore
 
 
-@events.on('lint_result_changed')
+@events.on(events.LINT_RESULT)
 def on_lint_result(filename, linter_name, reason=None, **kwargs):
     # type: (FileName, LinterName, Reason, Any) -> None
     LINT_RESULT_CACHE[linter_name].append((filename, reason))

diff --git a/status_bar_view.py b/status_bar_view.py
@@ -44,7 +44,7 @@ def plugin_unloaded():
             view.erase_status(STATUS_MSG_KEY)
 
 
-@events.on('lint_result_changed')
+@events.on(events.LINT_RESULT)
 def on_lint_result(filename, **kwargs):
     if State['active_filename'] == filename:
         draw(**State)

diff --git a/sublime_linter.py b/sublime_linter.py
@@ -164,9 +164,6 @@ def other_visible_views():
 guard_check_linters_for_view = defaultdict(threading.Lock)  # type: DefaultDict[Bid, threading.Lock]
 buffer_filenames = {}  # type: Dict[Bid, FileName]
 buffer_syntaxes = {}  # type: Dict[Bid, str]
-lint_results_cache = defaultdict(
-    lambda: defaultdict(tuple)
-)  # type: DefaultDict[FileName, DefaultDict[LinterName, Tuple[object, ...]]]
 
 
 class BackendController(sublime_plugin.EventListener):
@@ -244,7 +241,6 @@ def on_close(self, view):
         for fn in to_discard:
             persist.affected_filenames_per_filename.pop(fn, None)
             persist.file_errors.pop(fn, None)
-            lint_results_cache.pop(fn, None)
 
         persist.assigned_linters.pop(bid, None)
         guard_check_linters_for_view.pop(bid, None)
@@ -438,21 +434,13 @@ def group_by_filename_and_update(
 def update_file_errors(filename, linter, errors, reason=None):
     # type: (FileName, LinterName, List[LintError], Optional[Reason]) -> None
     """Persist lint error changes and broadcast."""
-    token = tuple(e['uid'] for e in errors) + (persist.settings.change_count(),)
-    modified = lint_results_cache[filename][linter] != token
-    lint_results_cache[filename][linter] = token
-
-    payload = {
+    update_errors_store(filename, linter, errors)
+    events.broadcast(events.LINT_RESULT, {
         'filename': filename,
         'linter_name': linter,
         'errors': errors,
         'reason': reason
-    }
-    if modified:
-        update_errors_store(filename, linter, errors)
-        events.broadcast('lint_result_changed', payload)
-
-    events.broadcast(events.LINT_RESULT, payload)
+    })
 
 
 def update_errors_store(filename, linter_name, errors):