Calculate column widths in the error panel #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
Before:
After:
|
kaste
force-pushed
the
auto-columns-for-panel-view
branch
from
819945a
to
102e9b8
Compare
Codecov Report
|
kaste
force-pushed
the
auto-columns-for-panel-view
branch
from
102e9b8
to
77a193f
Compare
kaste
force-pushed
the
auto-columns-for-panel-view
branch
from
77a193f
to
d959b2f
Compare
|
This is really smart and nice! Awesome. ⛵️ it! |
braver
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state is that e.g. the linter name column is 12 chars wide etc.
With this patch we compute the max length we need per column and use these values.