Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Snippet Formatting and Duplicates #83

Closed
bcrotty opened this issue Feb 9, 2015 · 6 comments
Closed

Clean Up Snippet Formatting and Duplicates #83

bcrotty opened this issue Feb 9, 2015 · 6 comments

Comments

@bcrotty
Copy link
Contributor

bcrotty commented Feb 9, 2015

Only one of the snippets includes a description tag, so most are using the file name for the name of the snippet, but even the file names are not all consistent. Also, the expanded text is not always formatted properly, such as the Set-PSDebug snippet, which should be capitalized as shown.

@vors
Copy link
Member

vors commented Feb 9, 2015

Can you give an example? Does it relate to #81?

@bcrotty
Copy link
Contributor Author

bcrotty commented Feb 11, 2015

I fixed all the issues I found in the commit https://github.com/bcrotty/PowerShell/commit/daeb3d007c61acc3e170cb6617be44e959abcded

@vors
Copy link
Member

vors commented Feb 11, 2015

Waiting for pull requests from you :)

@bcrotty
Copy link
Contributor Author

bcrotty commented Feb 11, 2015

Sorry. Still getting used to Git/GitHub. If I do a pull request can I do it in such a way that it only compares certain files or will it compare the whole thing?

@vors
Copy link
Member

vors commented Feb 11, 2015

It will compare the whole thing.
I would recommend you this reading http://nvie.com/posts/a-successful-git-branching-model/
Bottom-line: one branch per feature. Then PR to dev branch in origin (by origin, I always mean this repo).

To localize your changes in current situation, you can start new branch from origin/dev and cherry-pick commits that you want. There are other options to do that.

Don't hesitate to ask, if you have problems with git.

vors added a commit that referenced this issue Feb 26, 2015
Fix #83; standardize snippet formatting; remove duplicates
@bcrotty
Copy link
Contributor Author

bcrotty commented Feb 26, 2015

Merged with #90.

@bcrotty bcrotty closed this as completed Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants