Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Align describe snippets with it snippets for consistency. #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

rexikan commented Jun 25, 2012

Removed should from describe-snippets.

Benefits:

  • Describe snippets produce same it block as the it snippet.
  • Supports both it "should do something" and it "does something" styles.

I don't think I agree with removing the 'should' completely. It would be better to replace 'description' with 'should' instead. That way, you can just start typing 'does' when in that field of the snippet it active and highlighted, then it will just be replaced. Hopefully my assumption that the tmSnippets work like the native Sublime snippets wrt to the field behavior and defaulting...

Also, I think it is an incorrect assumption that the description for the describe and it statement should be the same format. They server different purposes, and defaulting to 'should' for the start of the 'it' description pushed for good BDD by reminding the developer that they are describing a behavior.

It would probably be best at some point to convert these all to Sublime native snippets, but these old TM snippets do the trick for now.

Thanks for the contributions!

Owner

rexikan replied Dec 14, 2012

My reason for removing "should" is that I follow the style of it "does something" instead of it "should do something". No big deal though.

@barneywilliams This PR should be closed, this has been addressed properly:

image

Member

princemaple commented Nov 3, 2014

Thank you @rexikan and @olivierlacan !

@princemaple princemaple closed this Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment