Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metadata based index instead of filesystem in queries #73

Closed
NattyNarwhal opened this issue Sep 28, 2022 · 2 comments · Fixed by #177
Closed

Use metadata based index instead of filesystem in queries #73

NattyNarwhal opened this issue Sep 28, 2022 · 2 comments · Fixed by #177
Labels
enhancement New feature or request refactor Code cleanup

Comments

@NattyNarwhal
Copy link
Member

For Navidrome, this doesn't matter, as it constructs traditional indices based on the metadata already, but Subsonic based servers will serve media as it's structured in the filesystem. This can be a real problem as you can't guarantee the artist/album/track structure. Newer versions of Subsonic support using metadata based structure for querying, but I don't know if the IDs will be the same for i.e artists. The XML tags look the same, albeit with a different structure.
@NattyNarwhal NattyNarwhal added enhancement New feature or request refactor Code cleanup labels Sep 28, 2022
NattyNarwhal added a commit that referenced this issue Oct 21, 2022
@NattyNarwhal
Try to mitigate GH-80
17d7774 
Not a real fix (doesn't handle common cases like artist/album/disc/track.ext),
but it does prevent bogus entries for being read. The real fix would
be to address GH-73.
@NattyNarwhal
Copy link
Member Author

This gets nastier with i.e. search2 song and getNowPlaying elements where they have the ID name but not the artist information. Really cool.

@NattyNarwhal NattyNarwhal mentioned this issue Nov 3, 2023
Closed
@NattyNarwhal NattyNarwhal pinned this issue Nov 9, 2023
@NattyNarwhal
Copy link
Member Author

I'm tempted to do this, especially since Navidrorme at least basically reuses IDs for both the fake hierarchy and ID3. It is a flag day for most other implementations though...

@NattyNarwhal NattyNarwhal mentioned this issue Nov 9, 2023
Merged
@NattyNarwhal NattyNarwhal mentioned this issue Nov 20, 2023
Closed
@NattyNarwhal NattyNarwhal unpinned this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tag instead of directory based metadata SubmarinerApp/Submariner
1 participant
@NattyNarwhal