Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Docker image building machinery #101

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore: remove Docker image building machinery #101

merged 1 commit into from
Jul 16, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Jul 4, 2024 •
edited
Loading

@SdgJlbl SdgJlbl requested a review from a team as a code owner July 4, 2024 09:23
@linear Linear
Copy link

linear bot commented Jul 4, 2024

FL-1637 Remove substra-tool base image

@SdgJlbl SdgJlbl force-pushed the chore/drop-image-building branch from 7acb796 to a7d8678 Compare July 4, 2024 09:25
ThibaultFy
ThibaultFy previously requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DockerFile is used in substra-ci

Dockerfile Outdated Show resolved Hide resolved
@thbcmlowk
Copy link
Contributor

/e2e

@Owlfred
Copy link

Owlfred commented Jul 4, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Jul 4, 2024

/e2e help

@Owlfred
Copy link

Owlfred commented Jul 4, 2024 

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                          Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-documentation, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>  Comma-separated list of tests to run. Valid options: sdk, substrafl, doc, frontend, mnist, camelyon or NONE. Frontend tests will run automatically on substrafl, mnist and camelyon if selected. (default: "sdk")
  -h, --help                              display help for command

@Substra Substra deleted a comment from Owlfred Jul 16, 2024
@Substra Substra deleted a comment from Owlfred Jul 16, 2024
@Substra Substra deleted a comment from Owlfred Jul 16, 2024
@Substra Substra deleted a comment from Owlfred Jul 16, 2024
@SdgJlbl
chore: remove Docker image building machinery
c696b71 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl merged commit 4ec9166 into main Jul 16, 2024
2 checks passed
@SdgJlbl SdgJlbl deleted the chore/drop-image-building branch July 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk left review comments

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

@ThibaultFy ThibaultFy Awaiting requested review from ThibaultFy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SdgJlbl @thbcmlowk @Owlfred @guilhem-barthes @ThibaultFy