Redefine the value of an item, not if it exists #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asking only if an ItemizedValueDict entry exists won't ask the user the right questions; specifically letting them change the value of their dict. In this case, I've been setting up interviews to automatically define
existsif asked for in this way, since usually I've been usingmove_checks_to_listto make objects already exist, yes / no. This means havingexistsandvaluere-edited doesn't ask two questions of the user.Additionally, adds a default
revisitquestion for the ALIncomeList object; otherwise edit buttons on review screens do nothing.Have tested with Affidavit Supplement, will likely merge without review, but feel free to give one post merge.