This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Adding consent component to email tool #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osahyoun
added a commit
that referenced
this pull request
Aug 9, 2022
* Added one more page for external ad agency pixels (#1987) * disable throttling on staging * Updates sentry key name (#1992) * disables api throttle * Adding consent component to email tool (#1995) * adding consent component to email tool * defaulting to false * conset required on email change if requiredNew * removed debugging code * checking consentRequired too * do not set false as default * Adds consent component to email MP tool (#2003) * Added confirm action & reminder email content for PT & AR (#2001) * Added gem to figure out test coverage (#1996) * Added gem to figure out test coverage * Adds command to store artifacts * Adds minimum coverage score * Removes coveralls * Update code coverage minimum score to 90 * Checks for double opt-in (#2005) * Checks for double optin * test commit * Revert "test commit" This reverts commit 183d4a1. * adding double opt in to the response * Revert "adding double opt in to the response" This reverts commit a00c759. * added double opt in to the response if the action is pending * Check for double optin on consent * Check for member consent * Adds pending action check for other email tools Co-authored-by: yeseniamolinab <yesi@sumofus.org> * Email double optin fixes (#2006) * Removes double optin check for emailMP * Adds country code to props on email pension tool * Check for pending action on the emails controller * Removes consent flag for double optin countries * Pass localpaymentmethods when setting direct debit (#2008) * Email tool redirections on double optin workflow (#2009) Co-authored-by: Subbiah <49471498+subbiahf22@users.noreply.github.com> Co-authored-by: yeseniamolinab <yesi@sumofus.org> Co-authored-by: subbiah <subbiah@f22labs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ticket
https://app.asana.com/0/1119304937718815/1202585536107850/f
Notes
This PR needs to include
Plugin:EmailToolas part of the following condition, so double opt-in works for the email tool too:https://github.com/SumOfUs/Champaign/blob/development/app/services/manage_action.rb#L135
Screenshots