Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #3

Closed
wants to merge 18 commits into from
Closed

test #3

wants to merge 18 commits into from

Conversation

YangFong
Copy link
Contributor

@YangFong YangFong commented Dec 6, 2021

主要修改的地方:

  • 组件参数变为可选
  • 使用默认参数与解构赋值,简化整体结构

当前重构了前三个,我想得到一个反馈,当前的手段是否可行

Copy link
Owner

@Summer-andy Summer-andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ! 感谢pr, 我今天中午过一遍哈

@Summer-andy
Copy link
Owner

我觉得ok

@YangFong
Copy link
Contributor Author

YangFong commented Dec 8, 2021

我觉得还好

好的,我将继续完善未完成的部分。

@YangFong
Copy link
Contributor Author

YangFong commented Dec 8, 2021

整理一下当中观察到的情况

  • 33 个组件测试成功,dome 当中缺失的是 <BlockRotateLoading/>
  • 部分组件可以使用伪元素重写
  • 使用默认参数代替了短路操作符
  • inColor 暂未启用

我在重构过程中对于 CSS 属性的位置摆放有点摸不着头,需要去了解一下回流与重绘,再考虑简化其中的 CSS。

@YangFong
Copy link
Contributor Author

YangFong commented Jan 4, 2022

嘿,经过一段时间的学习,我发现自己的提交有很多不妥的地方,这个 pr 就先关闭了,我需要重新整理一下。

@YangFong YangFong closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants