Support chef 16 by setting provides on custom resources. Fixes #178.
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Logic#178. This change maintains backwards compatibility with previous chef client versions. https://github.com/chef/chef/blob/master/RELEASE_NOTES.md#whats-new-in-16244 Signed-off-by: Eric Millbrandt <emillbrandt@brightcove.com>
|
This would be great to see merged |
|
@emillbrandt Thanks for PR. Please resolve conflicts :) |
sumo-drosiek
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change maintains backwards compatibility with previous chef client versions.
https://github.com/chef/chef/blob/master/RELEASE_NOTES.md#whats-new-in-16244
Signed-off-by: Eric Millbrandt emillbrandt@brightcove.com
Pull Request Checklist
Fixes #178.
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]and using a### Added, Fixed, Changed, or Breaking Changesub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
Known Compatibility Issues