Skip to content

Commit

Permalink
fix(otellogs): set fingerprint_size to 16kb to avoid of duplicated logs
Browse files Browse the repository at this point in the history
This prevents of open-telemetry/opentelemetry-collector-contrib#22936
which is caused by incorrect update of fingerprint when it is read in mutliple iterations.
The issue is not observed when fingerprint_size is not higher than default buffer size (16kb).
  • Loading branch information
kkujawa-sumo committed Jul 19, 2023
1 parent 5e99817 commit 33ba422
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions .changelog/3158.fixed.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix(otellogs): set fingerprint_size to 16kb to avoid of duplicated logs
5 changes: 3 additions & 2 deletions deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,11 @@ receivers:
{{- if .Values.sumologic.logs.container.enabled }}
filelog/containers:
{{ if lt (int .Capabilities.KubeVersion.Minor) 24 }}
## sets fingerprint_size to 17kb in order to match the longest possible docker line (which by default is 16kb)
## sets fingerprint_size to 16kb in order to match the longest possible docker line (which by default is 16kb)
## we want to include timestamp, which is at the end of the line
## setting higher fingerprint_size is not recommended when https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/22936 is not fixed
## Not necessary in 1.24 and later, as docker-shim is not present anymore
fingerprint_size: 17408
fingerprint_size: 16384
{{ end }}
include:
- /var/log/pods/*/*/*.log
Expand Down

0 comments on commit 33ba422

Please sign in to comment.