Skip to content

Commit

Permalink
feat(metrics/collector): adjust resources and autoscaling
Browse files Browse the repository at this point in the history 
This is based on internal dogfooding. The collector is, in general, is
heavily memory-bound, much like Prometheus.
  • Loading branch information
Mikołaj Świątek committed Aug 18, 2023
1 parent 692d97c commit 94d8880
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 12 deletions.
1 change: 1 addition & 0 deletions .changelog/3219.changed.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat(metrics/collector): adjust resources and autoscaling
6 changes: 3 additions & 3 deletions deploy/helm/sumologic/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `sumologic.metrics.serviceMonitors` | Configuration of Sumo Logic Kubernetes Collection components serviceMonitors | See [values.yaml] |
| `sumologic.metrics.collector.otelcol.enabled` | Enable experimental otelcol metrics collector | See [values.yaml] |
| `sumologic.metrics.collector.otelcol.scrapeInterval` | The default scrape interval for the collector. | `30s` |
| `sumologic.metrics.collector.otelcol.replicaCount` | Replica count for the experimental otelcol metrics collector | `3` |
| `sumologic.metrics.collector.otelcol.replicaCount` | Replica count for the experimental otelcol metrics collector | `1` |
| `sumologic.metrics.collector.otelcol.resources` | Resource requests and limits for the experimental otelcol metrics collector | See [values.yaml] |
| `sumologic.metrics.collector.otelcol.autoscaling.enabled` | Option to turn autoscaling on for the experimental otelcol metrics and specify params for HPA. Autoscaling needs metrics-server to access cpu metrics. collector | `false` |
| `sumologic.metrics.collector.otelcol.autoscaling.maxReplicas` | Default max replicas for autoscaling. collector | `10` |
| `sumologic.metrics.collector.otelcol.autoscaling.minReplicas` | Default min replicas for autoscaling. collector | `3` |
| `sumologic.metrics.collector.otelcol.autoscaling.targetCPUUtilizationPercentage` | The desired target CPU utilization for autoscaling. | `100` |
| `sumologic.metrics.collector.otelcol.autoscaling.targetMemoryUtilizationPercentage` | The desired target memory utilization for autoscaling. | `50` |
| `sumologic.metrics.collector.otelcol.autoscaling.targetCPUUtilizationPercentage` | The desired target CPU utilization for autoscaling. | `70` |
| `sumologic.metrics.collector.otelcol.autoscaling.targetMemoryUtilizationPercentage` | The desired target memory utilization for autoscaling. | `70` |
| `sumologic.metrics.collector.otelcol.serviceMonitorSelector` | Selector for ServiceMonitors used for target discovery. By default, we select ServiceMonitors created by the Chart. See: https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#opentelemetrycollectorspectargetallocatorprometheuscr | `Nil` |
| `sumologic.metrics.collector.otelcol.podMonitorSelector` | Selector for PodMonitors used for target discovery. By default, we select PodMonitors created by the Chart. See: https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#opentelemetrycollectorspectargetallocatorprometheuscr | `Nil` |
| `sumologic.metrics.collector.otelcol.nodeSelector` | Node selector for the experimental otelcol metrics. [See docs/best-practices.md for more information.](/docs/best-practices.md). | `{}` |
Expand Down
10 changes: 5 additions & 5 deletions deploy/helm/sumologic/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,8 @@ sumologic:
enabled: false
minReplicas: 3
maxReplicas: 10
targetCPUUtilizationPercentage: 100
# targetMemoryUtilizationPercentage: 50
targetCPUUtilizationPercentage: 70
targetMemoryUtilizationPercentage: 70

nodeSelector: {}

Expand All @@ -487,15 +487,15 @@ sumologic:
## Option to define priorityClassName to assign a priority class to pods.
priorityClassName:

replicaCount: 3
replicaCount: 1

resources:
limits:
memory: 1Gi
memory: 2Gi
cpu: 1000m
requests:
memory: 768Mi
cpu: 500m
cpu: 100m

## Selector for ServiceMonitors used for target discovery. By default, this selects resources created by this Chart.
## See https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#opentelemetrycollectorspectargetallocatorprometheuscr
Expand Down
6 changes: 3 additions & 3 deletions tests/helm/testdata/goldenfile/metrics_collector_otc/basic.output.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ metadata:
sumologic.com/scrape: "true"
spec:
mode: statefulset
replicas: 3
replicas: 1
serviceAccount: RELEASE-NAME-sumologic-metrics
targetAllocator:
serviceAccount: RELEASE-NAME-sumologic-metrics-targetallocator
Expand Down Expand Up @@ -45,9 +45,9 @@ spec:
resources:
limits:
cpu: 1000m
memory: 1Gi
memory: 2Gi
requests:
cpu: 500m
cpu: 100m
memory: 768Mi
volumes:
- name: tmp
Expand Down
2 changes: 1 addition & 1 deletion tests/helm/testdata/goldenfile/metrics_collector_otc/custom.output.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
podKey: podValue
spec:
mode: statefulset
replicas: 3
replicas: 1
serviceAccount: RELEASE-NAME-sumologic-metrics
targetAllocator:
serviceAccount: RELEASE-NAME-sumologic-metrics-targetallocator
Expand Down

0 comments on commit 94d8880

Please sign in to comment.