Skip to content

Commit

Permalink
feat: disable otel storage compaction on start
Browse files Browse the repository at this point in the history
With on_rebound compaction enabled, this isn't necessary anymore, and it
causes long startup times when the queue is large.
  • Loading branch information
Mikołaj Świątek committed Feb 14, 2023
1 parent 7ad390d commit ee36f3e
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions .changelog/2870.changed.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat: disable otel storage compaction on start
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ extensions:
directory: /var/lib/storage/otc
timeout: 10s
compaction:
on_start: true
on_rebound: true
# Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449
directory: /var/lib/storage/otc
Expand Down
1 change: 0 additions & 1 deletion deploy/helm/sumologic/conf/logs/otelcol/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ extensions:
directory: /var/lib/storage/otc
timeout: 10s
compaction:
on_start: true
on_rebound: true
# Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449
directory: /var/lib/storage/otc
Expand Down
1 change: 0 additions & 1 deletion deploy/helm/sumologic/conf/metrics/otelcol/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ extensions:
directory: /var/lib/storage/otc
timeout: 10s
compaction:
on_start: true
on_rebound: true
# Can't be /tmp yet, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/13449
directory: /var/lib/storage/otc
Expand Down
1 change: 0 additions & 1 deletion tests/helm/logs_otc/static/basic.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down
1 change: 0 additions & 1 deletion tests/helm/logs_otc/static/options.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down
1 change: 0 additions & 1 deletion tests/helm/metadata_logs_otc/static/otel.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down
1 change: 0 additions & 1 deletion tests/helm/metadata_logs_otc/static/templates.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down
1 change: 0 additions & 1 deletion tests/helm/metadata_metrics_otc/static/basic.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ data:
compaction:
directory: /var/lib/storage/otc
on_rebound: true
on_start: true
directory: /var/lib/storage/otc
timeout: 10s
health_check: {}
Expand Down

0 comments on commit ee36f3e

Please sign in to comment.