Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to include custom labels for fluentd services #1544

Closed
mozz-lx opened this issue Apr 8, 2021 · 1 comment · Fixed by #1550
Closed

add an option to include custom labels for fluentd services #1544

mozz-lx opened this issue Apr 8, 2021 · 1 comment · Fixed by #1550
Labels
enhancement New feature or request
Milestone

Comments

@mozz-lx
Copy link
Contributor

mozz-lx commented Apr 8, 2021

Is your feature request related to a problem? Please describe.
I our company we use a strict admission controller policy where all our delploys, sts, jobs, pods and services require a specific set of labels to allow the creation of those API objects.

I'm unable to complete the installation of sumologic-kubernetes-collection with out an option to include custom labels in this fluentd services like.

  • sumologic-sumologic-fluentd-logs-headless service
  • sumologic-sumologic-fluentd-events-headless service
  • sumologic-sumologic-fluentd-metrics-headless service

Describe the solution you'd like
Add an option to include custom labels in the values.yaml file for those fluentd headless services.
Could something like this.

fluentd:
  events:
    service:
      labels:
        label:1
        label:2

Other option can be to include these labels from values.fluentd.podlabels:

{{- if .Values.fluentd.podLabels }}
{{ toYaml .Values.fluentd.podLabels | indent 4 }}
{{- end }}

in the fluentd services.
metrics-service-headless
logs-service-headless
events-service-headless
events-service
metrics-service
logs-service

@mozz-lx mozz-lx added the enhancement New feature or request label Apr 8, 2021
@mozz-lx mozz-lx changed the title add an option to include custom labels for headless services add an option to include custom labels for fluentd services Apr 8, 2021
@mozz-lx
Copy link
Contributor Author

mozz-lx commented Apr 12, 2021

Added PR with my suggested fix
#1550

@perk-sumo perk-sumo added this to the v2.2 milestone Jun 7, 2021
@perk-sumo perk-sumo linked a pull request Jun 7, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants