Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vagrant values.yaml and add limits for prometheus #1024

Merged
merged 1 commit into from Oct 21, 2020
Merged

Fix vagrant values.yaml and add limits for prometheus #1024

merged 1 commit into from Oct 21, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description
  • prometheus key was under grafana key which according to helm show values prometheus-community/kube-prometheus-stack doesn't exist (yet it exists under prometheus-operator's root key)
  • add somewhat relaxes limits to vagrant prometheus to prevent OOMs
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo self-assigned this Oct 21, 2020
@pmalek-sumo pmalek-sumo merged commit 79f2888 into master Oct 21, 2020
@pmalek-sumo pmalek-sumo deleted the fix-vagrant-values-yaml branch October 21, 2020 16:56
pmalek-sumo added a commit that referenced this pull request Oct 22, 2020
@pmalek-sumo @pmalek
Fix vagrant values.yaml and add limits for prometheus (#1024)
3ed9abc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmalek-sumo @sumo-drosiek @pmalek