Remove overrides files, stop generating them and remove kubernetes directory #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
vsinghal13,
perk-sumo,
pmalek-sumo and
andrzej-stencel
sumo-drosiek
force-pushed
the
drosiek-remove-overrides
branch
from
b72ea74
to
79ed099
Compare
pmalek-sumo
approved these changes
Oct 29, 2020
sumo-drosiek
commented
Oct 29, 2020
sumo-drosiek
commented
Oct 29, 2020
vsinghal13
approved these changes
Oct 30, 2020
drduke1
approved these changes
Oct 30, 2020
|
Need to update documentation for |
sumo-drosiek
force-pushed
the
drosiek-remove-overrides
branch
from
20217d1
to
69a3e3f
Compare
|
Updated |
frankreno
approved these changes
Nov 2, 2020
| @@ -201,7 +201,7 @@ You can find more information on the `grep` filter plugin in the [fluentd docume | |||
| If you want to capture container logs to a container that writes locally, you will need to ensure the logs get mounted to the host so fluent-bit can be configured to capture from the host. | |||
|
|
|||
| Example: | |||
| In the fluentbit overrides file (https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/master/deploy/fluent-bit/overrides.yaml) in the `rawConfig section`, you have to add a new input specifying the file path, eg. | |||
| In `values.yaml` in the `fluent-bit.rawConfig` section, you have to add a new input specifying the file path, eg. | |||
There was a problem hiding this comment.
This will need modification once we upgrade the fluent-bit helm chart, as raw config goes away
drduke1
approved these changes
Nov 2, 2020
Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com>
sumo-drosiek
force-pushed
the
drosiek-remove-overrides
branch
from
00594a6
to
69231cf
Compare
This was referenced Nov 10, 2020
pmalek-sumo
approved these changes
Nov 10, 2020
sumo-drosiek
added a commit
that referenced
this pull request
Nov 10, 2020
sumo-drosiek
added a commit
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove overrides files, stop generating them and remove kubernetes directory
Testing performed