Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm from kubernetes-tools #1054

Merged
merged 4 commits into from Nov 2, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

No description provided.

@sumo-drosiek sumo-drosiek added this to the v2.0 milestone Oct 29, 2020
@sumo-drosiek sumo-drosiek force-pushed the drosiek-use-helm-from-tools branch 3 times, most recently from becfd8f to 706fa09 Compare October 29, 2020 14:54
@sumo-drosiek sumo-drosiek linked an issue Oct 29, 2020 that may be closed by this pull request
@sumo-drosiek sumo-drosiek changed the title [WIP] Use helm from kubernetes-tools \Use helm from kubernetes-tools Oct 29, 2020
@sumo-drosiek sumo-drosiek changed the title \Use helm from kubernetes-tools Use helm from kubernetes-tools Oct 29, 2020
@sumo-drosiek sumo-drosiek marked this pull request as draft October 29, 2020 15:03
@sumo-drosiek sumo-drosiek force-pushed the drosiek-use-helm-from-tools branch 9 times, most recently from 55c787c to 8e00963 Compare October 30, 2020 10:05
@sumo-drosiek sumo-drosiek marked this pull request as ready for review October 30, 2020 10:15
ci/build.sh Show resolved Hide resolved
ci/build.sh Show resolved Hide resolved
ci/build.sh Show resolved Hide resolved
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 but one thing seems fishy.

ci/build.sh Show resolved Hide resolved
ci/build.sh Show resolved Hide resolved
ci/build.sh Outdated
docker run --rm \
-v "$(pwd):/chart" \
-w /chart \
sumologic/kubernetes-tools:master \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be master but rather latest or just fixed version.

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's make sure we are on fixed tools version when it's ready.

@sumo-drosiek sumo-drosiek merged commit b48c134 into master Nov 2, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-use-helm-from-tools branch November 2, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the helm dependency from CI
3 participants