-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update autoscaling/v1 to autoscaling/v2beta2 #1071
Conversation
@frankreno @perk-sumo |
I agree with @sumo-drosiek. I feel like we should be able to handle this w/o a breaking change as well. In the values.yaml we can have the same key we do today ( |
The reason I'm hesitant on this approach is that
Not my call, just chippin' in :) |
There is one problem with doing a breaking change and fully migrating - it's still a |
Ok, sure. Let's do that then. |
Let's set it at 50% but not use it by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not change the values.yaml
keys around autoscaling just yet.
Removing |
@perk-sumo Please take a look one more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Update autoscaling/v1 to autoscaling/v2beta2 in order to enable custom metrics autoscaling and autoscaling based on memory utilization.
This PR adds
targetMemoryUtilizationPercentage
key to enable autoscaling based on memory utilization.ref: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/#autoscaling-on-multiple-metrics-and-custom-metrics
Testing performed