Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean up job to delete collector when collection is uninstalled #1092

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, too quikc. please dismiss it

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits but overall 👍 :)

deploy/helm/sumologic/conf/cleanup/cleanup.sh Outdated Show resolved Hide resolved
deploy/helm/sumologic/conf/cleanup/cleanup.sh Outdated Show resolved Hide resolved
@pmalek-sumo pmalek-sumo merged commit 3be3d86 into master Nov 16, 2020
@pmalek-sumo pmalek-sumo deleted the enable-collector-cleanup branch November 16, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants