Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byi helm yaml #11

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Byi helm yaml #11

merged 5 commits into from
Apr 15, 2019

Conversation

bin3377
Copy link

@bin3377 bin3377 commented Apr 12, 2019

  • move all stuff about fluentd into single .yaml file for easier setup
  • change service to internal
  • add files/steps for setting up Prometheus
    @lei-sumo @samjsong

deploy/README.md Outdated
@@ -0,0 +1,85 @@
# Deployment Guide (Draft)

## Rre-requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerequisites ?

deploy/README.md Outdated
## Rre-requests

* Make sure a Kubernetes cluster is created and you can use `kubectl` to access it.
* Make sure Kubernetes cluster enable the DNS service ([steps](https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#dns))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enable/enables

deploy/README.md Outdated
* Make sure a Kubernetes cluster is created and you can use `kubectl` to access it.
* Make sure Kubernetes cluster enable the DNS service ([steps](https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#dns))
* Create HTTP source(s) in your Sumo Logic account and get HTTP Source URL(s).
* Run `echo -n '<YOUR_HTTP_URL>' | base64` to encode the URL with base-64.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason we encode the URL with base64? Our other open source projects aren't asking the user to do this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets in Kubernetes require base64 encoded data in the yaml file. I believe alternatively we could do

stringData:
  endpoint-metrics: <URL>

rather than

data:
  endpoint-metrics: <encoded URL>

but then the customer is storing their endpoint in plain text, not sure if that's a concern.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base64 is plaintext :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh 😂nice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... I don't know it can be a plain text. That will be easier

Copy link
Author

@bin3377 bin3377 Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the plain text doesn't work:
my yaml:

apiVersion: v1
kind: Secret
metadata:
  name: sumologic
  namespace: sumologic
  labels:
    k8s-app: fluentd-sumologic
type: Opaque
data:
  stringData: https://stag-events.sumologic.net/receiver/v1/http/XXXX==

and when I apply it:

Error from server (BadRequest): error when creating "./fluentd-sumologic.yaml": Secret in version "v1" cannot be handled as a Secret: v1.Secret.ObjectMeta: v1.ObjectMeta.TypeMeta: Kind: Data: decode base64: illegal base64 data at input byte 5, error found in #10 byte of ...|ONAeDNA=="},"kind":"|..., bigger context ...|8-KUxvOfgLKqJMmoiq5-2divPm1_55jwiFAaqoq2ONAeDNA=="},"kind":"Secret","metadata":{"annotations":{"kube|...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, looks like I place it to wrong place...

Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment on wording

deploy/README.md Outdated
@@ -0,0 +1,84 @@
# Deployment Guide (Draft)

## Prerequests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "Prerequisites". "Prerequests" isn't a word

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂I need a spell checking plugin

@bin3377 bin3377 merged commit 702c726 into master Apr 15, 2019
@bin3377 bin3377 deleted the byi-helm-yaml branch April 15, 2019 17:36
@bin3377
Copy link
Author

bin3377 commented Apr 15, 2019

@ggarg2906sumo you can try with the new .yaml files

@ggarg2906sumo
Copy link

Thanks @bin3377 , I will try this :)

psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
Add decision on how to name collecotrs, roles, endpoints and sourceca…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants