-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byi helm yaml #11
Byi helm yaml #11
Conversation
deploy/README.md
Outdated
@@ -0,0 +1,85 @@ | |||
# Deployment Guide (Draft) | |||
|
|||
## Rre-requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prerequisites ?
deploy/README.md
Outdated
## Rre-requests | ||
|
||
* Make sure a Kubernetes cluster is created and you can use `kubectl` to access it. | ||
* Make sure Kubernetes cluster enable the DNS service ([steps](https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#dns)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/enable/enables
deploy/README.md
Outdated
* Make sure a Kubernetes cluster is created and you can use `kubectl` to access it. | ||
* Make sure Kubernetes cluster enable the DNS service ([steps](https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#dns)) | ||
* Create HTTP source(s) in your Sumo Logic account and get HTTP Source URL(s). | ||
* Run `echo -n '<YOUR_HTTP_URL>' | base64` to encode the URL with base-64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason we encode the URL with base64? Our other open source projects aren't asking the user to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secrets in Kubernetes require base64 encoded data in the yaml file. I believe alternatively we could do
stringData:
endpoint-metrics: <URL>
rather than
data:
endpoint-metrics: <encoded URL>
but then the customer is storing their endpoint in plain text, not sure if that's a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base64 is plaintext :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh 😂nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... I don't know it can be a plain text. That will be easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the plain text doesn't work:
my yaml:
apiVersion: v1
kind: Secret
metadata:
name: sumologic
namespace: sumologic
labels:
k8s-app: fluentd-sumologic
type: Opaque
data:
stringData: https://stag-events.sumologic.net/receiver/v1/http/XXXX==
and when I apply it:
Error from server (BadRequest): error when creating "./fluentd-sumologic.yaml": Secret in version "v1" cannot be handled as a Secret: v1.Secret.ObjectMeta: v1.ObjectMeta.TypeMeta: Kind: Data: decode base64: illegal base64 data at input byte 5, error found in #10 byte of ...|ONAeDNA=="},"kind":"|..., bigger context ...|8-KUxvOfgLKqJMmoiq5-2divPm1_55jwiFAaqoq2ONAeDNA=="},"kind":"Secret","metadata":{"annotations":{"kube|...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM, looks like I place it to wrong place...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment on wording
deploy/README.md
Outdated
@@ -0,0 +1,84 @@ | |||
# Deployment Guide (Draft) | |||
|
|||
## Prerequests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean "Prerequisites". "Prerequests" isn't a word
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂I need a spell checking plugin
@ggarg2906sumo you can try with the new .yaml files |
Thanks @bin3377 , I will try this :) |
Add decision on how to name collecotrs, roles, endpoints and sourceca…
service
to internal@lei-sumo @samjsong