Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only import sources when collector exists #1137

Merged
merged 2 commits into from Nov 19, 2020
Merged

Only import sources when collector exists #1137

merged 2 commits into from Nov 19, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

Only import sources when collector exists.
This should cut down the time needed for setup job to complete.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo self-assigned this Nov 19, 2020
@pmalek-sumo pmalek-sumo requested review from samjsong and removed request for a team November 19, 2020 16:29
perk-sumo
perk-sumo approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmalek-sumo pmalek-sumo merged commit 84b5f44 into master Nov 19, 2020
@pmalek-sumo pmalek-sumo deleted the only-import-sources-when-collector-exists branch November 19, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

@samjsong samjsong Awaiting requested review from samjsong

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmalek-sumo @perk-sumo @pmalek