Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate image to fluentd.image and sumologic.setup.job.image #1148

Merged
merged 4 commits into from Nov 24, 2020

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Nov 23, 2020

Description
  • migrate image to sumologic.setup.job.image and to fluentd.image (for now use the same image but prepare a separate image for setup job in a different PR)
  • add this to v2 migration script and add its tests to CI
  • change tests
  • adjust migration script (v1) tests as they used yq arguments which changed in 3.4.0 and now need to be provided differently - we might actually end up remove this script as it's only relevant to 1.x branches
  • bump yq in vagrant and on CI to 3.4.1
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor

Remove image from the values.yaml

@pmalek-sumo pmalek-sumo force-pushed the separate-setup-and-fluentd-images branch from 0f8a917 to 04630a4 Compare November 23, 2020 16:58
@pmalek-sumo pmalek-sumo linked an issue Nov 23, 2020 that may be closed by this pull request
@pmalek-sumo pmalek-sumo force-pushed the separate-setup-and-fluentd-images branch from 04630a4 to caa9b9b Compare November 23, 2020 17:09
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pmalek-sumo pmalek-sumo merged commit d1ed616 into master Nov 24, 2020
@pmalek-sumo pmalek-sumo deleted the separate-setup-and-fluentd-images branch November 24, 2020 10:36
@pmalek-sumo pmalek-sumo linked an issue Nov 24, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants