Migrate otelcol image name to otelcol image repository #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kkujawa-sumo,
perk-sumo and
sumo-drosiek
as code owners
pmalek-sumo
force-pushed
the
migrate-otelcol-image-key
branch
from
c686584
to
8ecfeef
Compare
pmalek-sumo
force-pushed
the
migrate-otelcol-image-key
branch
from
8ecfeef
to
38da807
Compare
sumo-drosiek
approved these changes
Nov 24, 2020
pmm-sumo
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Looks good. @mat-rumian we might need to udpate our user-facing docs to make sure we're consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
otelcol.deployment.image.name->otelcol.deployment.image.repositoryTesting performed