Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up collector keys in values.yaml #1160

Merged
merged 4 commits into from Nov 25, 2020
Merged

Clean up collector keys in values.yaml #1160

merged 4 commits into from Nov 25, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo self-assigned this Nov 24, 2020
@pmalek-sumo pmalek-sumo requested a review from a team November 24, 2020 17:39
@pmalek-sumo pmalek-sumo linked an issue Nov 24, 2020 that may be closed by this pull request
Clean up Sumo related resource keys in values.yaml #1068
Closed
sumo-drosiek
sumo-drosiek reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to one list format?
you changes from - to * and in another file you introduces -

Pretty confusing

@pmalek-sumo
Copy link
Contributor Author

Can we stick to one list format?
you changes from - to * and in another file you introduces -

Pretty confusing

mdl warns about inconsistent usage of list bullets in single file not across files. Not sure if we can enforce it.

@sumo-drosiek
Copy link
Contributor

would be nice to be consistent across the PR

@pmalek-sumo pmalek-sumo added this to the v2.0 milestone Nov 25, 2020
@pmalek-sumo pmalek-sumo merged commit 94641cc into main Nov 25, 2020
@pmalek-sumo pmalek-sumo deleted the cleanup-values-yaml branch November 25, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@frankreno frankreno Awaiting requested review from frankreno

@kkujawa-sumo kkujawa-sumo Awaiting requested review from kkujawa-sumo

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees

@pmalek-sumo pmalek-sumo

Labels
breaking-change
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Clean up Sumo related resource keys in values.yaml
3 participants
@pmalek-sumo @sumo-drosiek @pmalek