Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expose-prometheus target in Makefile #1189

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix expose-prometheus target in Makefile #1189

merged 1 commit into from
Nov 30, 2020

Conversation

kkujawa-sumo
Copy link
Contributor

Description

Fixes following error:

$sumo-make expose-prometheus
kubectl port-forward -n "sumologic" service/collection-prometheus-oper-prometheus --address=0.0.0.0 9090
Error from server (NotFound): services "collection-prometheus-oper-prometheus" not found
make: *** [/sumologic/vagrant/Makefile:122: expose-prometheus] Error 1
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@kkujawa-sumo kkujawa-sumo requested a review from a team November 30, 2020 08:50
@kkujawa-sumo kkujawa-sumo added the bug Something isn't working label Nov 30, 2020
pmalek-sumo
pmalek-sumo approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkujawa-sumo kkujawa-sumo merged commit 5ae6862 into main Nov 30, 2020
@kkujawa-sumo kkujawa-sumo deleted the kkujawa-fix-expose-prometheus branch November 30, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@frankreno frankreno Awaiting requested review from frankreno

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kkujawa-sumo @sumo-drosiek @pmalek-sumo