select metrics #12
Merged
select metrics #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
approved these changes
Apr 16, 2019
| </match> | ||
| <filter prometheus.datapoint> | ||
| @type carbon_v2 | ||
| </filter> | ||
| </filter> | ||
| # <filter prometheus.datapoint> |
There was a problem hiding this comment.
I think we should remove the comment
There was a problem hiding this comment.
It's for easier debugging. I'm ok to remove it
lei-sumo
approved these changes
Apr 18, 2019
| @@ -1,4 +1,58 @@ | |||
| prometheus: | |||
| prometheusSpec: | |||
| remoteWrite: | |||
| - url: http://fluentd:9888/prometheus.metrics | |||
| - url: http://fluentd:9888/prometheus.metrics.state.daemonset | |||
There was a problem hiding this comment.
Are these new url matching to the source endpoints created by Sam's PR?
There was a problem hiding this comment.
I don't think these urls need to match with the source endpoints created by my PR. Since fluentd accepts all of these metrics from prometheus and more or less treats them all the same (since they are all retagged with prometheus.datapoint). Then we separate the metrics again by job to send to the source endpoints on Sumo's end.
There was a problem hiding this comment.
yes. they are transformed to same tag in datapoint filter stage so no impact. spliting them into different urls maybe benefit for the statistics later.
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* adr 7 * Update and rename 0007-controlling-role-access-through-ad.md to 0008-controlling-role-access-through-ad.md
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* Instructions for using the adutil * Update security team's filter (SumoLogic#99) * PUBP-8182: provision elections collector (SumoLogic#98) * PUBP-8182: provision elections collector * PUBP-8182: provision elections collector * PUBP-8182: renaming module to match repo name * PUBP-8182: renaming output Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com> * Add logging for AD parameters (SumoLogic#95) * Log the vars subitted * fix wording, enumerate commands directly * drone sign Co-authored-by: Marcin Suterski <msuterski@users.noreply.github.com> * added collector for nytm/dv-drone in TF (SumoLogic#100) * Adding collector for spg-inyt-subscription-api (SumoLogic#101) * remove 'manageIndexes' from samizdat role (SumoLogic#102) * Add ADR regarding AD groups and nesting (SumoLogic#12) * adr 7 * Update and rename 0007-controlling-role-access-through-ad.md to 0008-controlling-role-access-through-ad.md * Feature/add collector int fallback role (SumoLogic#104) * adding new collector to the role * adding new collector to the role * Adutil instructions moved to dv-docs * update link Co-authored-by: Marcin Suterski <msuterski@users.noreply.github.com> Co-authored-by: Shreelekha Tanna <shree.tanna@nytimes.com> Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com> Co-authored-by: Prune Sebastien THOMAS <prune@lecentre.net> Co-authored-by: satyabodharao <47533173+satyabodharao@users.noreply.github.com> Co-authored-by: Shawn Bower <shawn.bower@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter the metrics from write api config following https://docs.google.com/document/d/1z0KFYygDMahOXsXrAYPOwmSkTmSDTOhUdVwOwxXusv0
@frankreno @samjsong @lei-sumo
FYI - @rvmiller89 @ggarg2906sumo