Upgrade script v2 - fluentd.persistence migration #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kkujawa-sumo,
perk-sumo and
sumo-drosiek
as code owners
sumo-drosiek
reviewed
Dec 3, 2020
| control-plane: /fluentd/buffer/metrics.control_plane | ||
| default: /fluentd/buffer/metrics.default | ||
| events: /fluentd/buffer/events | ||
| traces: /fluentd/buffer/traces |
There was a problem hiding this comment.
Are all of this keys required to check persistence?
There was a problem hiding this comment.
Nope but the more the better right :)? I can easily remove them
There was a problem hiding this comment.
It depends 😀
I would drop them due to test redability
pmalek-sumo
force-pushed
the
upgrade-v2-script-fluentd-persistence
branch
from
c57ec49
to
62a82e6
Compare
pmalek-sumo
force-pushed
the
upgrade-v2-script-fluentd-persistence
branch
from
62a82e6
to
b225ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade script v2 - fluentd.persistence migration
Testing performed