Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-setup Dockerfile #1226

Merged
merged 1 commit into from Dec 8, 2020
Merged

kubernetes-setup Dockerfile #1226

merged 1 commit into from Dec 8, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo self-assigned this Dec 7, 2020
@pmalek-sumo pmalek-sumo force-pushed the setupjob-separate-image branch 3 times, most recently from 33ee4cf to 3bc7cd6 Compare December 7, 2020 20:38
andrzej-stencel
andrzej-stencel previously approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in love with the setupjob single word 🤪
How about setup-job or just setup?

@perk-sumo
Copy link
Contributor

How about setup-job or just setup?

I'd go with simple setup.

@pmalek-sumo pmalek-sumo force-pushed the setupjob-separate-image branch 10 times, most recently from 5696b9a to 2d59f7d Compare December 8, 2020 13:42
@pmalek-sumo pmalek-sumo changed the title setupjob Dockerfile kubernetes-setup Dockerfile Dec 8, 2020
@pmalek-sumo pmalek-sumo marked this pull request as ready for review December 8, 2020 14:02
@pmalek-sumo pmalek-sumo requested a review from a team December 8, 2020 14:02
andrzej-stencel
andrzej-stencel approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@pmalek-sumo pmalek-sumo merged commit e6a1e1d into main Dec 8, 2020
@pmalek-sumo pmalek-sumo deleted the setupjob-separate-image branch December 8, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@kkujawa-sumo kkujawa-sumo Awaiting requested review from kkujawa-sumo

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@frankreno frankreno Awaiting requested review from frankreno

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmalek-sumo @perk-sumo @andrzej-stencel @pmalek