Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check minimal k8s version before installation #1240

Merged
merged 3 commits into from Dec 15, 2020
Merged

Check minimal k8s version before installation #1240

merged 3 commits into from Dec 15, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Fixes #1195

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek added this to the v2.0 milestone Dec 15, 2020
@sumo-drosiek sumo-drosiek requested a review from a team December 15, 2020 08:11
perk-sumo
perk-sumo reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm overall good but please make it 2 commits (one for .gitignore and another for the changes) or split to 2 PRs.

@sumo-drosiek
Copy link
Contributor Author

sumo-drosiek commented Dec 15, 2020 •
edited

@perk-sumo done

@sumo-drosiek sumo-drosiek merged commit 20365f0 into main Dec 15, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-chck-mnml-k8s-vrsn branch December 15, 2020 08:51
@sumo-drosiek sumo-drosiek mentioned this pull request Dec 15, 2020
Closed
@pmalek-sumo pmalek-sumo mentioned this pull request Dec 22, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

@frankreno frankreno Awaiting requested review from frankreno

@kkujawa-sumo kkujawa-sumo Awaiting requested review from kkujawa-sumo

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add helm check for the minimal k8s version requirement
3 participants
@sumo-drosiek @perk-sumo @andrzej-stencel