Explicitly log that setup.sh is missing when using custom setup scripts #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
force-pushed
the
explicit-failure-logging-for-custom-scripts
branch
from
ac6628e
to
c89e4cc
Compare
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kkujawa-sumo,
perk-sumo and
sumo-drosiek
as code owners
Comment on lines
40
to
42
| [[ ! -f setup.sh ]] \ | ||
| && echo "You're missing setup.sh script in custom scripts directory: '${dir}'" \ | ||
| && continue |
There was a problem hiding this comment.
I think if then would be better to use here than oneliner
pmalek-sumo
force-pushed
the
explicit-failure-logging-for-custom-scripts
branch
from
14ba5d3
to
4498e74
Compare
|
@perk-sumo @sumo-drosiek Please +1 I had to make commits pretty 🙄 |
sumo-drosiek
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fill in your description here.
Testing performed