Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Debian fluentd Dockerfile #125

Merged
merged 3 commits into from Aug 7, 2019
Merged

Switch to Debian fluentd Dockerfile #125

merged 3 commits into from Aug 7, 2019

Conversation

rvmiller89
Copy link
Contributor

@rvmiller89 rvmiller89 commented Aug 6, 2019 •
edited

The fluentd-kubernetes daemonset has deprecated using Alpine as their base image, and also says

The following repository expose images based on Alpine Linux and Debian. For production environments we strongly suggest to use Debian images.

This PR changes our fluentd Docker image to be based on Debian.

Testing performed:

  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events logs and normal logs and metrics are still coming in

@rvmiller89 rvmiller89 force-pushed the rmiller-debian-fluentd-deployment branch from 00c213d to 0fda44e Compare August 6, 2019 20:26
samjsong
samjsong approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we're okay with switching to debian 👍

frankreno
frankreno approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing I am going to do is to run this thru our TwistLock partner license and do a vulnerability scan

@rvmiller89 rvmiller89 merged commit 152cca5 into master Aug 7, 2019
@rvmiller89 rvmiller89 deleted the rmiller-debian-fluentd-deployment branch August 7, 2019 16:55
@rvmiller89
Copy link
Contributor Author

@frankreno the new image is 0.0.23-alpha if you want to run that through the vuln scan. Unfortunately the size is almost double using the Debian base image @ 158 MB. Not sure how big of a deal that is for customers, but something to note.

@rvmiller89 rvmiller89 mentioned this pull request Aug 7, 2019
Merged
3 tasks
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@melmaliacone
Uncomment test pipeline (SumoLogic#125)
704390d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@lei-sumo lei-sumo Awaiting requested review from lei-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvmiller89 @frankreno @samjsong