Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade v2 script - metrics server #1282

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Upgrade v2 script - metrics server #1282

merged 1 commit into from
Jan 4, 2021

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Jan 4, 2021 •
edited
Loading

Description

Add missing metrics-server migration for v2 migration script.

This will cover migration between old helm chart's args and bitnami's chart extraArgs

Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo added this to the v2.0 milestone Jan 4, 2021
@pmalek-sumo pmalek-sumo self-assigned this Jan 4, 2021
@pmalek-sumo pmalek-sumo requested a review from a team January 4, 2021 12:32
@pmalek-sumo pmalek-sumo linked an issue Jan 4, 2021 that may be closed by this pull request
Migrate metrics-server to bitnami chart in v2 migration script #1280
Closed
perk-sumo
perk-sumo approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pmalek-sumo pmalek-sumo merged commit ab09128 into main Jan 4, 2021
@pmalek-sumo pmalek-sumo deleted the upgrade-v2-script-metrics-server branch January 4, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@frankreno frankreno Awaiting requested review from frankreno

@kkujawa-sumo kkujawa-sumo Awaiting requested review from kkujawa-sumo

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Migrate metrics-server to bitnami chart in v2 migration script
3 participants
@pmalek-sumo @perk-sumo @pmalek