Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about warning when resource managed by helm is modified #1300

Merged
merged 1 commit into from Jan 8, 2021

Conversation

kkujawa-sumo
Copy link
Contributor

Description

Add information about warning when resource managed by helm is modified


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Comment on lines 187 to 188
**Notice** Warning will appear after running command above when DaemonSet managed by helm is modified,
example form of the warning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Notice** Warning will appear after running command above when DaemonSet managed by helm is modified,
example form of the warning:
**Notice**: When DaemonSet managed by helm is modified by the command specified above, one might expect
a warning similar to the one below:

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kkujawa-sumo kkujawa-sumo merged commit e6f56c9 into main Jan 8, 2021
@kkujawa-sumo kkujawa-sumo deleted the kk-warning-info branch January 8, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants