Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add empty lines to Fluent-bit config #1318

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Jan 12, 2021

Description

Empty lines are ok in Fluent-bit config but they cause problems in yaml files so just drop empty lines when migrating Fluent-bit configuration.

Additionally, change Fluent-bit config indentation to 4 spaces instead of 2 because fluent bit chart uses 4 spaces:

https://github.com/fluent/helm-charts/blob/e6805d4509868b76717677c7f7eecc4834d49d5a/charts/fluent-bit/templates/configmap.yaml#L8-L15


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@kkujawa-sumo
Copy link
Contributor

kkujawa-sumo commented Jan 12, 2021

I still see this error:

kubectl logs my-release-fluent-bit-sgq9m
[2021/01/12 10:40:04] [  Error] File /fluent-bit/etc/fluent-bit.conf
[2021/01/12 10:40:04] [  Error] Error in line 12: Invalid indentation level
Fluent Bit v1.6.8
* Copyright (C) 2019-2020 The Fluent Bit Authors
* Copyright (C) 2015-2018 Treasure Data
* Fluent Bit is a CNCF sub-project under the umbrella of Fluentd
* https://fluentbit.io

@pmalek-sumo pmalek-sumo force-pushed the v2-migration-script-fluent-bit-conf-fix branch from b21906d to 7c6e861 Compare January 12, 2021 11:21
@kkujawa-sumo
Copy link
Contributor

with the latest changes it works :)

@pmalek-sumo pmalek-sumo merged commit 8f38c56 into main Jan 12, 2021
@pmalek-sumo pmalek-sumo deleted the v2-migration-script-fluent-bit-conf-fix branch January 12, 2021 11:43
@pmalek-sumo pmalek-sumo linked an issue Jan 13, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare 1.x to 2.x migration script
3 participants