Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate yaml from helm chart on commits #137

Merged
merged 20 commits into from Aug 12, 2019
Merged

Generate yaml from helm chart on commits #137

merged 20 commits into from Aug 12, 2019

Conversation

maimaisie
Copy link
Contributor

@maimaisie maimaisie commented Aug 9, 2019 •
edited

Description

On every commit, CI will auto-generate fluentd-sumologic.yaml.tmpl if it detects any diffs between the output of helm template and the current file.

Will need to test the generated yaml before merging.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

yuting-liu
yuting-liu approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@yuting-liu yuting-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maimaisie maimaisie merged commit bb4708c into master Aug 12, 2019
@maimaisie maimaisie deleted the maisie-yaml-automation branch August 12, 2019 23:33
@rvmiller89
Copy link
Contributor

Master build is failing, we should either revert or fix this: https://travis-ci.org/SumoLogic/sumologic-kubernetes-collection/builds/571492109

$ bash ci/build.sh
Detected manual changes in 'fluentd-sumologic.yaml.tmpl', abort.
The command "bash ci/build.sh" exited with 1.

psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@mlclmj @melmaliacone
add olivier to ecomm (SumoLogic#137)
8436960 
Co-authored-by: Mel Cone <7332210+melmaliacone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvmiller89 rvmiller89 rvmiller89 left review comments

@yuting-liu yuting-liu yuting-liu approved these changes

@samjsong samjsong samjsong approved these changes

@lei-sumo lei-sumo Awaiting requested review from lei-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maimaisie @rvmiller89 @yuting-liu @samjsong