Fix link to Fluentd output configuration #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkujawa-sumo
requested review from
andrzej-stencel,
frankreno,
perk-sumo,
pmalek-sumo and
sumo-drosiek
as code owners
pmalek-sumo
reviewed
Jan 25, 2021
deploy/docs/v1_conf_examples.md
Outdated
| @@ -105,7 +105,7 @@ Reference documentation: [Fluentd Filter Plugin](https://docs.fluentd.org/filter | |||
|
|
|||
| The example below shows how you can override the entire output section for the container logs pipeline. | |||
|
|
|||
| You can look at the Default output section [here](https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/conf/logs/logs.source.containers.conf#L51) | |||
| You can look at the Default output section [here](https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/conf/logs/logs.source.containers.conf#L75) | |||
There was a problem hiding this comment.
Wouldn't we prefer to bind this to a commit instead of main?
kkujawa-sumo
force-pushed
the
kk-fix-link-fluentd-conf
branch
from
92f50d9
to
e4ee0d1
Compare
2 tasks
sumo-drosiek
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to
logs.source.containers.conf#L51was introduced in e96ace9 on that daylogs.source.containers.confhad form from this commit: 3e50bc0Currently content from
logs.source.containers.conf#L51is available inlogs.source.containers.conf#L75.Testing performed