Byi fix timeseries #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
approved these changes
Apr 24, 2019
| log.trace "protobuf::parse - in: (#{text.bytesize}/#{inflated.bytesize}), out: #{decoded.timeseries.length}" | ||
| record = {} | ||
| record[KEY_TIMESERIES] = decoded.timeseries | ||
| yield Fluent::EventTime.now, record |
There was a problem hiding this comment.
Do we override the time eventually using the value in record itself?
There was a problem hiding this comment.
yes. this time is only used in fluentd pipeline
|
cc @ggarg2906sumo This is supposed to fix the missing metrics issue. |
|
@ggarg2906sumo new image pushed to dockerhub now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem: only one point goes into pipeline in one HTTP request.
The problems are:
parse(text)withyieldreturn with time and record (e.g. hash)refer to:
https://docs.fluentd.org/v0.12/articles/plugin-development#parser-plugins
https://github.com/fluent/fluentd/tree/master/lib/fluent/plugin
update unit test make sure the time stamp and records are correctly bring in.
verified with private docker image on stag. the timeseries now giving points in fixed interval