Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only pass in our own yamls to helm template cmd #148

Merged
merged 13 commits into from Aug 19, 2019
Merged

Only pass in our own yamls to helm template cmd #148

merged 13 commits into from Aug 19, 2019

Conversation

maimaisie
Copy link
Contributor

@maimaisie maimaisie commented Aug 19, 2019 •
edited

Description

After adding dependencies into our helm chart, helm template will render not only our own yaml templates but also the yaml templates from all of the dependent charts. To render only our templates, we use the -x option for each .yaml file under sumologic/templates folder in the helm template command.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@maimaisie maimaisie merged commit 57fa26e into yuting-helm-dependency Aug 19, 2019
@maimaisie maimaisie deleted the maisie-fix-helm-template branch August 19, 2019 23:19
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@msuterski
Add Suman as manager of the int-fallback group (SumoLogic#148)
ec74447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maimaisie @yuting-liu