vagrant: add script to get kubeconfig for vagrant cluster #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
andrzej-stencel,
frankreno,
kkujawa-sumo,
perk-sumo and
pmalek-sumo
as code owners
perk-sumo
approved these changes
Mar 9, 2021
kkujawa-sumo
approved these changes
Mar 9, 2021
pmalek-sumo
reviewed
Mar 9, 2021
vagrant/scripts/get-kubeconfig.sh
Outdated
| readonly CONFIG_PATH="${ROOT_DIR}/tmp/config" | ||
| readonly KUBECONFIG_PATH=~/.kube/config | ||
|
|
||
| pushd "${ROOT_DIR}" |
There was a problem hiding this comment.
add a popd, ideally in a trap
| # This script replaces kubeconfig with configuration for vagrant cluster | ||
|
|
||
| readonly DIR="$(realpath "$(dirname "${BASH_SOURCE[0]}")")" | ||
| readonly ROOT_DIR="${DIR}/../../" |
There was a problem hiding this comment.
Wouldn't it be better to operate in /tmp/ instead of littering the repo?
There was a problem hiding this comment.
Thats an idea 🤔
REPO_ROOT/tmp is gitignored
There was a problem hiding this comment.
It may be gitignored but still it adds "one-use" junk to repo dir.
sumo-drosiek
force-pushed
the
drosiek-get-kubeconfig
branch
from
c5ef206
to
99abc56
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-get-kubeconfig
branch
from
99abc56
to
242132d
Compare
pmalek-sumo
reviewed
Mar 9, 2021
| clean_up | ||
| exit 1 | ||
| } | ||
| trap 'err_report $LINENO' ERR |
There was a problem hiding this comment.
Suggested change
| trap 'err_report $LINENO' ERR | |
| trap clean_up INT | |
| trap 'err_report $LINENO' ERR |
?
There was a problem hiding this comment.
It doesn't work 😞
pmalek-sumo
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vagrant: add script to get kubeconfig for vagrant cluster
Testing performed