Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symlinks to legacy helm override files #154

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

rvmiller89
Copy link
Contributor

Description

We previously added these symlinks for old versions of the setup script that downloaded the resources directly, but since Github doesn't actually resolve the symlink (they would only get the filename as the contents of the symlink), we might as well clean these up.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@rvmiller89 rvmiller89 merged commit 9970be3 into master Aug 30, 2019
@rvmiller89 rvmiller89 deleted the rmiller-remove-legacy-symlink branch August 30, 2019 00:11
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants